Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH 1/3] extcon: max8997: select IRQ_DOMAIN instead of depending on it | Date | Sun, 12 Feb 2023 20:15:33 -0800 |
| |
IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky.
Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues.
Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to "select".
Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> Cc: Donggeun Kim <dg77.kim@samsung.com> Cc: Marc Zyngier <maz@kernel.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Peter Rosin <peda@axentia.se> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- I have a similar patch (should be a series) for REGMAP.
drivers/extcon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -115,7 +115,8 @@ config EXTCON_MAX77843 config EXTCON_MAX8997 tristate "Maxim MAX8997 EXTCON Support" - depends on MFD_MAX8997 && IRQ_DOMAIN + depends on MFD_MAX8997 + select IRQ_DOMAIN help If you say yes here you get support for the MUIC device of Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory
| |