lkml.org 
[lkml]   [2023]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [v2] dmaengine: dw-edma: reduce stack usage after debugfs rework
    On Fri, Feb 10, 2023 at 05:29:40PM -0600, Bjorn Helgaas wrote:
    > On Fri, Feb 10, 2023 at 03:35:25PM +0300, Serge Semin wrote:
    > > On Fri, Feb 10, 2023 at 02:22:28PM +0530, Vinod Koul wrote:
    > > > On 30-01-23, 19:50, Arnd Bergmann wrote:
    > > > > From: Arnd Bergmann <arnd@arndb.de>
    > > > >
    > > > > After the dw_edma_debugfs_entry arrays are no longer compile-time
    > > > > constant, they take up space on the stack, which exceeds the warning
    > > > > limit after inlining:
    > > > >
    > > > > drivers/dma/dw-edma/dw-edma-v0-debugfs.c:280:6: error: stack frame size (1784) exceeds limit (1400) in 'dw_edma_v0_debugfs_on' [-Werror,-Wframe-larger-than]
    > > > > void dw_edma_v0_debugfs_on(struct dw_edma *dw)
    > > > >
    > > > > Work around this by preventing dw_edma_debugfs_regs_{wr,rd} from both
    > > > > being inlined together, which cuts the stack frame size in half and
    > > > > makes it fit below the warning limit.
    > > > >
    > > > > Fixes: 5c0373eafd83 ("dmaengine: dw-edma: Move eDMA data pointer to debugfs node descriptor")
    > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > > > > ---
    > > > > v2: rebase on top of dmaengine tree
    > > >
    > > > I dont have 5c0373eafd83 in my tree, I guess that went thru PCI tree, so
    > > > I am going to defer this after merge window
    > >
    > > It's in the @Bjorn tree now
    > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ctrl/dwc&id=5c0373eafd8334343da22338d8588ed61e8daba0
    > >
    > > If you are ok with the fix then @Bjorn could take the patch in to his
    > > repo. Right, @Bjorn?
    >

    > Yes, I squashed this into the original patch and tweaked the
    > whitespace per Manivannan's comment.

    Great! Thanks.

    >
    > Note that we've moved to a shared PCI git tree, so the helgaas/pci.git
    > tree is obsolete and will bit rot until we remove it completely.
    >
    > The new one is:
    >
    > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/

    Good to know. Thanks again.

    -Serge(y)

    >
    > Bjorn

    \
     
     \ /
      Last update: 2023-03-27 00:19    [W:2.816 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site