lkml.org 
[lkml]   [2023]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules
    On Fri, Feb 10, 2023 at 08:10:43PM +0000, Conor Dooley wrote:
    > On Fri, Feb 10, 2023 at 07:26:38PM +0000, Nick Alcock wrote:
    > > On 10 Feb 2023, Conor Dooley said:
    > > > FYI $subject seems wrong, this is a PCI patch AFAICT.

    <...>

    > > kbuild is present in every patch in the series because this is a
    > > kbuild-driven change (the thing it disturbs is part of the build system,
    > > the construction of modules.builtin*). This seems to be common practice
    > > for kbuild-related treewide changes.
    >
    > Okay, I'll take your word for it. It just looked/looks odd to me!

    It looks odd to me too. Please add SPDX tag in modules which don't have
    it already, instead of commenting code.

    Thanks

    \
     
     \ /
      Last update: 2023-03-27 00:19    [W:7.759 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site