Messages in this thread | | | Date | Sun, 12 Feb 2023 20:37:17 +0200 | From | Leon Romanovsky <> | Subject | Re: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules |
| |
On Fri, Feb 10, 2023 at 08:10:43PM +0000, Conor Dooley wrote: > On Fri, Feb 10, 2023 at 07:26:38PM +0000, Nick Alcock wrote: > > On 10 Feb 2023, Conor Dooley said: > > > FYI $subject seems wrong, this is a PCI patch AFAICT.
<...>
> > kbuild is present in every patch in the series because this is a > > kbuild-driven change (the thing it disturbs is part of the build system, > > the construction of modules.builtin*). This seems to be common practice > > for kbuild-related treewide changes. > > Okay, I'll take your word for it. It just looked/looks odd to me!
It looks odd to me too. Please add SPDX tag in modules which don't have it already, instead of commenting code.
Thanks
| |