Messages in this thread | | | Date | Sun, 12 Feb 2023 17:14:49 +0100 | Subject | Re: [PATCH v2 1/8] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC | From | Krzysztof Kozlowski <> |
| |
On 10/02/2023 21:03, Bartosz Golaszewski wrote: > On Wed, Feb 8, 2023 at 12:08 PM Linus Walleij <linus.walleij@linaro.org> wrote: >> >> On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: >> >>> Currently all Rockchip gpio nodes have the same compatible. >>> Compatible strings should be SoC related. >>> >>> Signed-off-by: Johan Jonker <jbx6244@gmail.com> >> >> Bartosz can you merge this one patch and keep the rest back >> so we get a more defined DT binding baseline? >> >> Yours, >> Linus Walleij > > Krzysztof, you left your ack but seem to also have pointed out an > issue - do you want me to fix it up somehow before applying? Drop the > oneOf and turn it back into an enum?
Sure, you can apply with my comment fixed but then just please check with `make dt_binding_check DT_SCHEMA_FILES="xxx.yaml"`, that indentation is not mixed up.
Best regards, Krzysztof
| |