lkml.org 
[lkml]   [2023]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] remoteproc: qcom: fix sparse warnings
    From
    Friendly reminder.

    -Mukesh

    On 1/31/2023 9:31 PM, Mukesh Ojha wrote:
    > This patch try to address below sparse warnings.
    >
    > drivers/remoteproc/qcom_common.c:126:27: warning: restricted __le32 degrades to integer
    > drivers/remoteproc/qcom_common.c:133:32: warning: cast to restricted __le32
    > drivers/remoteproc/qcom_common.c:133:32: warning: cast from restricted __le64
    >
    > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
    > ---
    > drivers/remoteproc/qcom_common.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
    > index 020349f..7133c1f 100644
    > --- a/drivers/remoteproc/qcom_common.c
    > +++ b/drivers/remoteproc/qcom_common.c
    > @@ -123,14 +123,14 @@ static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsy
    >
    > for (i = 0; i < seg_cnt; i++) {
    > memcpy_fromio(&region, ptr + i, sizeof(region));
    > - if (region.valid == MD_REGION_VALID) {
    > + if (le32_to_cpu(region.valid) == MD_REGION_VALID) {
    > name = kstrdup(region.name, GFP_KERNEL);
    > if (!name) {
    > iounmap(ptr);
    > return -ENOMEM;
    > }
    > da = le64_to_cpu(region.address);
    > - size = le32_to_cpu(region.size);
    > + size = le64_to_cpu(region.size);
    > rproc_coredump_add_custom_segment(rproc, da, size, NULL, name);
    > }
    > }

    \
     
     \ /
      Last update: 2023-03-27 00:19    [W:3.107 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site