Messages in this thread | | | Date | Sun, 12 Feb 2023 08:09:17 +0100 | From | Greg KH <> | Subject | Re: [PATCH v5 char-misc-next] misc: microchip: pci1xxxx: Add OTP/EEPROM driver for the pci1xxxx switch |
| |
On Sun, Feb 12, 2023 at 09:27:43AM +0530, Tharun Kumar P wrote: > + /* Wait for the EPC_BUSY bit to get cleared */ > + do { > + data = readl(priv->reg_base + MMAP_EEPROM_OFFSET(EEPROM_CMD_REG)); > + } while (data & EEPROM_CMD_EPC_BUSY_BIT);
Again, you can not sit and spin in a busy-wait like this with no chance to recover if something goes wrong with the hardware (hint, what if it got removed?)
please fix.
thanks,
greg k-h
| |