lkml.org 
[lkml]   [2023]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 char-misc-next] misc: microchip: pci1xxxx: Add OTP/EEPROM driver for the pci1xxxx switch
    On Sun, Feb 12, 2023 at 09:27:43AM +0530, Tharun Kumar P wrote:
    > + /* Wait for the EPC_BUSY bit to get cleared */
    > + do {
    > + data = readl(priv->reg_base + MMAP_EEPROM_OFFSET(EEPROM_CMD_REG));
    > + } while (data & EEPROM_CMD_EPC_BUSY_BIT);

    Again, you can not sit and spin in a busy-wait like this with no chance
    to recover if something goes wrong with the hardware (hint, what if it
    got removed?)

    please fix.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2023-03-27 00:19    [W:5.220 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site