Messages in this thread | | | Date | Fri, 10 Feb 2023 17:54:12 +0200 | Subject | Re: [PATCH v3 5/5] arm64: dts: qcom: sm8450: add dp controller | From | Dmitry Baryshkov <> |
| |
On 10/02/2023 17:28, Neil Armstrong wrote: > On 10/02/2023 16:24, Dmitry Baryshkov wrote: >> On 10/02/2023 16:44, Neil Armstrong wrote: >>> Add the Display Port controller subnode to the MDSS node. >>> >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>> --- >>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 79 >>> ++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 79 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> index 6caa2c8efb46..72d54beb7d7c 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> @@ -2751,6 +2751,13 @@ dpu_intf2_out: endpoint { >>> }; >>> }; >>> + port@2 { >>> + reg = <2>; >>> + dpu_intf0_out: endpoint { >>> + remote-endpoint = <&mdss_dp0_in>; >>> + }; >>> + }; >>> + >>> }; >>> mdp_opp_table: opp-table { >>> @@ -2783,6 +2790,78 @@ opp-500000000 { >>> }; >>> }; >>> + mdss_dp0: displayport-controller@ae90000 { >>> + compatible = "qcom,sm8350-dp"; > > Exact, must fix. > >> >> Missing "qcom,sm8450-dp". As I wrote in the comment to patch 1, I'd >> suggest having just a single entry here rather than keeping both 8350 >> and 8450 entries. >> >>> + reg = <0 0xae90000 0 0xfc>, >>> + <0 0xae90200 0 0xc0>, >>> + <0 0xae90400 0 0x770>, >>> + <0 0xae91000 0 0x98>, >>> + <0 0xae91400 0 0x98>; >> >> >> While this sounds correct, usually we used the even size here (0x200, >> 0x400, etc.). Can we please switch to it (especially since sm8350-dp >> uses even sizes). > > I don't have access to registers layout for HDK8450 but the system > freezes when using even sizes, using > the exact register size works fine.
Interesting. Could you please trace, what exactly makes it fail, since specifying bigger region size should not cause such issues.
-- With best wishes Dmitry
| |