lkml.org 
[lkml]   [2023]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: gadget: u_serial: Add null pointer check in gserial_resume
On Fri, Feb 10, 2023 at 12:26:52PM +0530, Prashanth K wrote:
>
>
> > And this seems like a viable option to me, what do you suggest?
> >
> > gserial_disconnect {
> >     spin_lock(static)
> >     spin_lock(port)
> >     ...
> >     gser->ioport = NULL;
> >     ...
> >     spin_lock(port)
> >     spin_unlock(static)
> >
> > }
> >
> > gserial_resume {
> >     struct gs_port *port = gser->ioport;
> >
> >     spin_lock(static)
> >     if (!port)
> spin_unlock(static)
> >         return
> >     spin_lock(port)

If you want, you could move the spin_unlock(static) up to here. It
probably doesn't matter.

> >
> >     ...
> >     spin_unlock(port)
> >     spin_unlock(static)
> > }

I agree, that should work fine.

Alan Stern

\
 
 \ /
  Last update: 2023-03-27 00:18    [W:0.056 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site