Messages in this thread | | | Subject | Re: [PATCH v2] media: mediatek: vcodec: Force capture queue format to MM21 | From | Nicolas Dufresne <> | Date | Fri, 10 Feb 2023 10:36:25 -0500 |
| |
Le vendredi 10 février 2023 à 13:55 +0800, Yunfei Dong a écrit : > In order to conver the format of capture queue from mediatek MM21 to > standard yuv420 with Libyuv, need to force capture queue format to > MM21 for Libyuv can't covert mediatek MT21 format at current period.
Please rework this text, it is hard to understand.
> > Fixes: 7501edef6b1f ("media: mediatek: vcodec: Different codec using different capture format") > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.org> > --- > changed with v1: > - add Fixes tag. > --- > drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > index 641f533c417f..4f5e9c20214f 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > @@ -41,7 +41,7 @@ static bool mtk_vdec_get_cap_fmt(struct mtk_vcodec_ctx *ctx, int format_index) > const struct mtk_video_fmt *fmt; > struct mtk_q_data *q_data; > int num_frame_count = 0, i; > - bool ret = true; > + bool ret = false; > > for (i = 0; i < *dec_pdata->num_formats; i++) { > if (dec_pdata->vdec_formats[i].type != MTK_FMT_FRAME) > @@ -63,7 +63,7 @@ static bool mtk_vdec_get_cap_fmt(struct mtk_vcodec_ctx *ctx, int format_index) > case V4L2_PIX_FMT_H264_SLICE: > case V4L2_PIX_FMT_VP9_FRAME: > if (fmt->fourcc == V4L2_PIX_FMT_MM21) > - ret = false; > + ret = true;
This makes the VP8 and the other cases identical, leaving anything that touches MT21 as dead code. I'm not sure, cause I cannot test it, but it should in theory render MT8192 unusable, unless a new firmware has been submitted to linux- firmware with MM21 support ?
> break; > default: > ret = true;
| |