lkml.org 
[lkml]   [2023]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 08/11] arm64: dts: qcom: sm8350-hdk: add pmic glink node
On 10/02/2023 16:21, Konrad Dybcio wrote:
>
>
> On 10.02.2023 16:02, Neil Armstrong wrote:
>> Add the pmic glink node linked with the DWC3 USB controller
>> switched to OTG mode and tagged with usb-role-switch.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 77 ++++++++++++++++++++++++++++-----
>> 1 file changed, 65 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
>> index 54654eb75c28..28fc9a835c5d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
>> @@ -31,6 +31,40 @@ hdmi_con: endpoint {
>> };
>> };
>>
>> + pmic-glink {
>> + compatible = "qcom,sm8350-pmic-glink", "qcom,pmic-glink";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + connector@0 {
>> + compatible = "usb-c-connector";
>> + reg = <0>;
>> + power-role = "dual";
>> + data-role = "dual";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> +
>> + pmic_glink_hs_in: endpoint {
>> + remote-endpoint = <&usb_1_dwc3_hs>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + pmic_glink_ss_in: endpoint {
>> + remote-endpoint = <&usb_1_dwc3_ss>;
>> + };
>> + };
>> + };
>> + };
>> + };
>> +
>> vph_pwr: vph-pwr-regulator {
>> compatible = "regulator-fixed";
>> regulator-name = "vph_pwr";
>> @@ -666,23 +700,42 @@ &usb_1 {
>> };
>>
>> &usb_1_dwc3 {
>> - /* TODO: Define USB-C connector properly */
>> - dr_mode = "peripheral";
>> -};
>> + dr_mode = "otg";
>> + usb-role-switch;
>>
>> -&usb_1_hsphy {
> Are you removing the hsphy completely?

Oops seems I did remove too much stuff... thx for noticing

>
> Konrad
>> - status = "okay";
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>>
>> - vdda-pll-supply = <&vreg_l5b_0p88>;
>> - vdda18-supply = <&vreg_l1c_1p8>;
>> - vdda33-supply = <&vreg_l2b_3p07>;
>> + port@0 {
>> + reg = <0>;
>> +
>> + usb_1_dwc3_hs: endpoint {
>> + remote-endpoint = <&pmic_glink_hs_in>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + usb_1_dwc3_ss: endpoint {
>> + remote-endpoint = <&pmic_glink_ss_in>;
>> + };
>> + };
>> + };
>> };
>>
>> -&usb_1_qmpphy {
>> - status = "okay";
>> +&usb_1_dwc3 {
>> + dr_mode = "otg";
>> + usb-role-switch;
>> +};
>>
>> - vdda-phy-supply = <&vreg_l6b_1p2>;
>> - vdda-pll-supply = <&vreg_l1b_0p88>;
>> +&usb_1_dwc3_hs {
>> + remote-endpoint = <&pmic_glink_hs_in>;
>> +};
>> +
>> +&usb_1_dwc3_ss {
>> + remote-endpoint = <&pmic_glink_ss_in>;
>> };
>>
>> &usb_2 {
>>

\
 
 \ /
  Last update: 2023-03-27 00:17    [W:0.070 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site