Messages in this thread | | | Date | Fri, 10 Feb 2023 15:01:16 +0100 | From | Benjamin Tissoires <> | Subject | Re: [PATCH 1/3] HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip. |
| |
On Feb 10 2023, Aditya Garg wrote: > > > Were the changes needed for these structs to be const in the > > linux-input tree for 6.3? If so then if you're applying the patches > > onto linus' tree that might be why there are errors about consts. > > I’d want the maintainers comment on this. Imo, these 2 structures needn’t be constantified.
The struct hid_ll_driver has to be constified, because otherwise it will introduce an error/warning when this patch is merged in the hid tree.
For the struct hid_driver, as mentioned previously I don't think we have the hid-core changes for that, and so you can't really constify them.
Cheers, Benjamin
> > Also, it would be nice if we could get a review on the other 2 patches, so that a v2 can be prepared.
| |