Messages in this thread | | | From | Sergio Paracuellos <> | Date | Fri, 10 Feb 2023 14:14:11 +0100 | Subject | Re: [PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers |
| |
On Fri, Feb 10, 2023 at 2:03 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 10/02/2023 13:17, Sergio Paracuellos wrote: > > MT7621 SoC provides a system controller node for accessing to some registers. > > Add a phandle in this node to avoid using MIPS related arch operations and > > includes in watchdog driver code. > > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > --- > > .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > index b2b17fdf4..cc701e920 100644 > > --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > @@ -19,6 +19,12 @@ properties: > > reg: > > maxItems: 1 > > > > + ralink,sysctl: > > Thanks for the changes. I did not notice it before - isn't Ralink part > of Mediatek now? Also compatible is mediatek, not "ralink"?
Yes, it is. I was using the same prefix as for the memory controller syscon phandler inside the 'sysc' node [0].
I have no problems at all in changing this to 'mediatek' if preferred.
Thanks, Sergio Paracuellos
[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/ralink/mt7621.dtsi#n67 > > > > Best regards, > Krzysztof >
| |