Messages in this thread | | | Date | Fri, 10 Feb 2023 12:38:09 +0100 | Subject | Re: [PATCH V2 1/3] dt-bindings: clock: Add Loongson-1 clock | From | Krzysztof Kozlowski <> |
| |
On 09/02/2023 14:26, Keguang Zhang wrote: > Add devicetree binding document and related header file > for the Loongson-1 clock. > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > --- > V1 -> V2: Change to one clock controller > Add clock-related dt-binding header file > Fix the warning of dt_binding_check > ---
Thank you for your patch. There is something to discuss/improve.
> diff --git a/include/dt-bindings/clock/loongson,ls1x-clk.h b/include/dt-bindings/clock/loongson,ls1x-clk.h > new file mode 100644 > index 000000000000..579552c5f14b > --- /dev/null > +++ b/include/dt-bindings/clock/loongson,ls1x-clk.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */
Same license as binding please.
> +/* > + * Loongson-1 clock tree IDs > + * > + * Copyright (C) 2023 Keguang Zhang <keguang.zhang@gmail.com> > + */
Best regards, Krzysztof
| |