lkml.org 
[lkml]   [2023]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver
On Fri, Feb 10, 2023 at 11:44:22AM +0100, Neil Armstrong wrote:
> On 10/02/2023 11:38, Greg Kroah-Hartman wrote:
> > On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote:
> > > On 31/01/2023 10:16, Greg Kroah-Hartman wrote:
> > > > On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote:
> > > > > Introduce the UCSI PMIC Glink aux driver that communicates
> > > > > with the aDSP firmware with the UCSI protocol which handles
> > > > > the USB-C Port(s) Power Delivery.
> > > > >
> > > > > The UCSI messaging is necessary on newer Qualcomm SoCs to
> > > > > provide USB role switch and altmode notifications.
> > > > >
> > > > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > > > ---
> > > > > drivers/usb/typec/ucsi/Kconfig | 7 +
> > > > > drivers/usb/typec/ucsi/Makefile | 1 +
> > > > > drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++
> > > > > 3 files changed, 329 insertions(+)
> > > > >
> > > > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> > > > > index 8f9c4b9f31f7..dee6069e46a2 100644
> > > > > --- a/drivers/usb/typec/ucsi/Kconfig
> > > > > +++ b/drivers/usb/typec/ucsi/Kconfig
> > > > > @@ -58,4 +58,11 @@ config UCSI_STM32G0
> > > > > To compile the driver as a module, choose M here: the module will be
> > > > > called ucsi_stm32g0.
> > > > > +config UCSI_PMIC_GLINK
> > > > > + tristate "UCSI Qualcomm PMIC GLINK Interface Driver"
> > > > > + depends on QCOM_PMIC_GLINK
> > > >
> > > > No way to test build this code without this option?
> > >
> > > Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed
> >
> > Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for
> > it to be built on all platforms properly? Otherwise you are
> > guaranteeing you will not get much, if any, build coverage and api
> > changes will cause this code to stagnate over time :(
>
> The QCOM_PMIC_GLINK deps are:
> depends on RPMSG
> depends on TYPEC
> depends on DRM
> depends on NET
> depends on OF
> select AUXILIARY_BUS
> select QCOM_PDR_HELPERS
>
> What would be the changes needed here ?

I do not know, try unwinding it and maybe just adding a COMPILE_TEST
build option in a few places is all that is needed?

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-03-27 00:17    [W:0.580 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site