Messages in this thread Patch in this message | | | Date | Fri, 10 Feb 2023 10:56:57 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v2 11/11] net: dsa: mt7530: use external PCS driver |
| |
On Tue, Feb 07, 2023 at 02:24:17PM +0000, Daniel Golle wrote: > @@ -2728,11 +2612,11 @@ mt753x_phylink_mac_select_pcs(struct dsa_switch *ds, int port, > > switch (interface) { > case PHY_INTERFACE_MODE_TRGMII: > + return &priv->pcs[port].pcs; > case PHY_INTERFACE_MODE_SGMII: > case PHY_INTERFACE_MODE_1000BASEX: > case PHY_INTERFACE_MODE_2500BASEX: > - return &priv->pcs[port].pcs; > - > + return priv->ports[port].sgmii_pcs;
My only concern here is that we also use the PCS when in TRGMII mode in this driver, but the mtk pcs code from mtk_eth_soc doesn't handle TRGMII (and getting the link timer will fail for this mode, causing the pcs_config() method to fail.)
Thus, this driver will stop working in TRGMII mode.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |