Messages in this thread | | | Date | Fri, 10 Feb 2023 12:43:22 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication |
| |
On Thu, Feb 09, 2023 at 04:38:08PM -0600, Mario Limonciello wrote: > Currently the PSP semaphore communication base address is discovered > by using an MSR that is not architecturally guaranteed for future > platforms. Also the mailbox that is utilized for communication with > the PSP may have other consumers in the kernel, so it's better to > make all communication go through a single driver.
...
> #if IS_ENABLED(CONFIG_I2C_DESIGNWARE_AMDPSP) > int i2c_dw_amdpsp_probe_lock_support(struct dw_i2c_dev *dev); > -void i2c_dw_amdpsp_remove_lock_support(struct dw_i2c_dev *dev); > #endif
...
> #ifdef CONFIG_I2C_DESIGNWARE_AMDPSP > { > .probe = i2c_dw_amdpsp_probe_lock_support, > - .remove = i2c_dw_amdpsp_remove_lock_support, > }, > #endif
Personally I found better to have empty stub for the sake of symmetry of API. But at the end it's not my decision, just felt that I have to express this.
-- With Best Regards, Andy Shevchenko
| |