lkml.org 
[lkml]   [2023]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] soc: aspeed: Add UART DMA support
From
On 10/02/2023 08:26, Chia-Wei Wang wrote:
> This driver provides DMA support for AST26xx UART and VUART
> devices. It is useful to offload CPU overhead while using
> UART/VUART for binary file transfer.
>
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> ---
> drivers/soc/aspeed/Kconfig | 9 +
> drivers/soc/aspeed/Makefile | 1 +
> drivers/soc/aspeed/aspeed-udma.c | 447 +++++++++++++++++++++++++
> include/linux/soc/aspeed/aspeed-udma.h | 34 ++

NAK.

DMA drivers do not go to soc, but to dma subsystem.

> 4 files changed, 491 insertions(+)
> create mode 100644 drivers/soc/aspeed/aspeed-udma.c
> create mode 100644 include/linux/soc/aspeed/aspeed-udma.h
>

(...)

> +
> + return 0;
> +}
> +
> +static const struct of_device_id aspeed_udma_match[] = {
> + { .compatible = "aspeed,ast2600-udma" },

Undocumented compatible.

Please run scripts/checkpatch.pl and fix reported warnings.



Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-27 00:17    [W:0.153 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site