| From | "Edgecombe, Rick P" <> | Subject | Re: [PATCH v2 7/8] x86/mm: only check uniform after calling mtrr_type_lookup() | Date | Sat, 11 Feb 2023 00:06:05 +0000 |
| |
On Thu, 2023-02-09 at 08:22 +0100, Juergen Gross wrote: > diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c > index e4f499eb0f29..7b9c5443d176 100644 > --- a/arch/x86/mm/pgtable.c > +++ b/arch/x86/mm/pgtable.c > @@ -721,8 +721,7 @@ int pud_set_huge(pud_t *pud, phys_addr_t addr, > pgprot_t prot) > u8 mtrr, uniform;
'mtrr' is now unused. Can it be dropped? Same for the pmd_set_huge().
> > mtrr = mtrr_type_lookup(addr, addr + PUD_SIZE, &uniform); > - if ((mtrr != MTRR_TYPE_INVALID) && (!uniform) && > - (mtrr != MTRR_TYPE_WRBACK)) > + if (!uniform) > return 0;
|