lkml.org 
[lkml]   [2023]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] maple: remove unneeded maple_bus_uevent() callback.
From
Date
Hi Greg!

On Wed, 2023-02-01 at 13:56 +0100, Greg Kroah-Hartman wrote:
> The driver core recently changed the uevent bus callback to take a const
> pointer, and the maple_bus_uevent() was not correctly fixed up. Instead
> of fixing the function parameter types, just remove the callback
> entirely as it does not do anything, so it is not necessary.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> sh maintainers, I'll take this through my tree as that's where the
> offending commit is that causes the build breakage.
>
> drivers/sh/maple/maple.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c
> index e24e220e56ee..e05473c5c267 100644
> --- a/drivers/sh/maple/maple.c
> +++ b/drivers/sh/maple/maple.c
> @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr,
> return 0;
> }
>
> -static int maple_bus_uevent(struct device *dev,
> - struct kobj_uevent_env *env)
> -{
> - return 0;
> -}
> -
> static void maple_bus_release(struct device *dev)
> {
> }
> @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = {
> struct bus_type maple_bus_type = {
> .name = "maple",
> .match = maple_match_bus_driver,
> - .uevent = maple_bus_uevent,
> };
> EXPORT_SYMBOL_GPL(maple_bus_type);

Through which tree is this supposed to be picked up?

FWIW, we have set up a new SH tree now, but I am not designated as an official
SH maintainer yet which is what I would like to become in order to support
Rich Felker.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

\
 
 \ /
  Last update: 2023-03-27 00:06    [W:0.055 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site