Messages in this thread | | | Date | Wed, 1 Feb 2023 20:32:06 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 4/7] gpiolib: remove gpio_set_debounce |
| |
On Tue, Jan 31, 2023 at 09:44:31PM -0800, Dmitry Torokhov wrote: > On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:
...
> > - return !gpio_get_value(ts->gpio_pendown); > > + return !gpiod_get_value(ts->gpio_pendown); > > No, we can not blindly do that without checking annotations on GPIOs.
But this is easy to fix, i.e. use raw API, no?
> > + ts->gpio_pendown = gpiod_get(&spi->dev, "pendown-gpio", GPIOD_IN); > > Wrong name, you will be looking for "pendown-gpio-gpios". > > Sorry, but I have to NAK this in the current form.
Oh, indeed. On top of that the conversion missing the label to be set.
-- With Best Regards, Andy Shevchenko
| |