Messages in this thread | | | Date | Wed, 01 Feb 2023 18:00:09 +0100 | From | "Sven Peter" <> | Subject | Re: [PATCH v2] iommu: dart: DART_T8110_ERROR range should be 0 to 5 |
| |
Hi,
On Wed, Feb 1, 2023, at 13:42, Eric Curtin wrote: > This was detected by smatch as one "else if" statement could never be > reached. Confirmed bit order by comparing with python implementation [1]. > > drivers/iommu/apple-dart.c:991 apple_dart_t8110_irq() > warn: duplicate check 'error_code == ((((1))) << (3))' > (previous on line 989) > > Link: https://github.com/AsahiLinux/m1n1/commit/96b2d584feec1e3f7bfa [1] > > Fixes: d8bcc870d99d ("iommu: dart: Add t8110 DART support") > Reported-by: Dan Carpenter <error27@gmail.com> > Signed-off-by: Eric Curtin <ecurtin@redhat.com
You're missing a ">" here but I hope Joerg can fix that when merging it!
> --- > Changes in v2: Remove DART_T8110_ERROR_ADDR_HI change > ---
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Thanks,
Sven
| |