Messages in this thread Patch in this message | | | From | Ye Bin <> | Subject | [PATCH 5/5] ext4: make sure fs error flag setted before clear journal error | Date | Wed, 1 Feb 2023 19:46:51 +0800 |
| |
From: Ye Bin <yebin10@huawei.com>
Now, jounral error number maybe cleared even though ext4_commit_super() failed. This may lead to error flag miss, then fsck will miss to check file system deeply.
Signed-off-by: Ye Bin <yebin10@huawei.com> --- fs/ext4/super.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index ab136d08d93d..c36cc9708258 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -6146,11 +6146,13 @@ static int ext4_clear_journal_err(struct super_block *sb, errstr = ext4_decode_error(sb, j_errno, nbuf); ext4_warning(sb, "Filesystem error recorded " "from previous mount: %s", errstr); - ext4_warning(sb, "Marking fs in need of filesystem check."); EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; es->s_state |= cpu_to_le16(EXT4_ERROR_FS); - ext4_commit_super(sb); + j_errno = ext4_commit_super(sb); + if (j_errno) + return j_errno; + ext4_warning(sb, "Marked fs in need of filesystem check."); jbd2_journal_clear_err(journal); jbd2_journal_update_sb_errno(journal); -- 2.31.1
| |