lkml.org 
[lkml]   [2023]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v1 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request
    On 2023-01-30 07:21:31, Kalyan Thota wrote:
    > Add dspp blocks into the topology for reservation, if there is a ctm
    > request for that composition.

    DSPP

    > Changes in v1:
    > - Minor nits (Dmitry)

    This should go below the triple dashes, so that it /does not/ become
    part of the patch/commit that is applied to the tree (where review
    history is irrelevant as it can be searched for separately).

    > Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
    > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    > ---
    > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 ++++++-------
    > 1 file changed, 6 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
    > index 9c6817b..3bd46b4 100644
    > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
    > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
    > @@ -545,7 +545,8 @@ bool dpu_encoder_use_dsc_merge(struct drm_encoder *drm_enc)
    > static struct msm_display_topology dpu_encoder_get_topology(
    > struct dpu_encoder_virt *dpu_enc,
    > struct dpu_kms *dpu_kms,
    > - struct drm_display_mode *mode)
    > + struct drm_display_mode *mode,
    > + struct drm_crtc_state *crtc_state)
    > {
    > struct msm_display_topology topology = {0};
    > int i, intf_count = 0;
    > @@ -573,11 +574,9 @@ static struct msm_display_topology dpu_encoder_get_topology(
    > else
    > topology.num_lm = (mode->hdisplay > MAX_HDISPLAY_SPLIT) ? 2 : 1;
    >
    > - if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) {
    > - if (dpu_kms->catalog->dspp &&
    > - (dpu_kms->catalog->dspp_count >= topology.num_lm))
    > - topology.num_dspp = topology.num_lm;
    > - }
    > + if (dpu_kms->catalog->dspp &&
    > + crtc_state->ctm && (dpu_kms->catalog->dspp_count >= topology.num_lm))

    Multiline-if-clause is typically indented with two tabs, not a half tab
    (4 spaces).

    Nit: swap the && here? dspp and dspp_count are related, so check ctm
    first or last but not in the middle - makes reading easier.

    > + topology.num_dspp = topology.num_lm;
    >
    > topology.num_enc = 0;
    > topology.num_intf = intf_count;
    > @@ -643,7 +642,7 @@ static int dpu_encoder_virt_atomic_check(
    > }
    > }
    >
    > - topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, adj_mode);
    > + topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, adj_mode, crtc_state);
    >
    > /* Reserve dynamic resources now. */
    > if (!ret) {
    > --
    > 2.7.4
    >

    \
     
     \ /
      Last update: 2023-03-27 00:04    [W:2.398 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site