Messages in this thread | | | Date | Wed, 1 Feb 2023 11:14:04 +0100 | Subject | Re: [PATCH 3/3] ARM: dts: aspeed: Add device tree for Ufispace NCPLite BMC | From | Krzysztof Kozlowski <> |
| |
On 01/02/2023 11:06, Jordan Chang wrote: >>> + gpio-keys { >>> + compatible = "gpio-keys"; >>> + >>> + fan-status-int-l { >> >> Does not look like you tested the DTS against bindings. Please run `make >> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst >> for instructions). >> >> These will bring warnings. Missing generic name, >> > I have run the `make dtbs_check` command, and did not notice the warning > message 'Missing generic name'. It shows lots of compatible failed messages. > - /ahb/ftgmac@1e670000: failed to match any schema with compatible:
You can run it with DT_SCHEMA_FILES=gpio-keys
> >>> + label = "fan-status-int-l"; >>> + gpios = <&gpio0 ASPEED_GPIO(M, 2) GPIO_ACTIVE_LOW>; >>> + linux,code = <ASPEED_GPIO(M, 2)>; >>> + }; >>> +
(...)
>>> + >>> +&i2c4 { >>> + status = "okay"; >>> + >>> + psu@58 { >>> + compatible = "pmbus"; >> >> Where is this compatible documented? > Can not find the corresponding document. >> >> Did you run checkpatch? Did it pass without warnings? > Yes, I did run the ./scripts/checkpatch.pl and there were two warnings left. > - WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > - WARNING: line length of 104 exceeds 100 columns > I just ignore those warnings that Joel has informed me in the previous > mail loop. >
Hm, is it then correct compatible?
Best regards, Krzysztof
| |