Messages in this thread | | | Date | Wed, 1 Feb 2023 12:26:28 +0300 | From | Nikita Shubin <> | Subject | Re: [PATCH v2] gpio: ep93xx: split device in multiple |
| |
On Wed, 01 Feb 2023 10:18:47 +0100 Alexander Sverdlin <alexander.sverdlin@gmail.com> wrote:
> Hello Nikita, > > On Wed, 2023-02-01 at 12:10 +0300, Nikita Shubin wrote: > > This prepares ep93xx SOC gpio to convert into device tree driver: > > - dropped banks and legacy defines > > - split AB IRQ and make it shared > > > > We are relying on IRQ number information A, B ports have single > > shared IRQ, while F port have dedicated IRQ for each line. > > > > Also we had to split single ep93xx platform_device into multiple, > > one for each port, without this we can't do a full working > > transition from legacy platform code into device tree capable. All > > GPIO_LOOKUP were change to match new chip namings. > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > --- > > Bart, i've rebased on the top of gpio/for-next (there were issues > > indeed), but this patch still won't apply. That's becouse it's > > dependant on Linus patch: > > https://lore.kernel.org/linux-arm-kernel/20230111132210.134478-1-linus.walleij@linaro.org/T/ > > > > Alexander can we have Linus patch somehow applied to ep93xx ? > > in contrast to me Linus and Bartosz do maintain their GPIO tree, > from my side I've performed a quick test, so it's OK from my PoV to > apply, but I cannot really assist here more. >
Oh sorry about that, i thought if it refers to "arch/arm/mach-ep93xx/core.c" - you or Hartley should apply them.
> Linus and Bartosz do maintain their GPIO tree
Then it should already exist in gpio/for-next ;).
``` echo heartbeat > /sys/class/leds/platform\:grled/trigger echo heartbeat > /sys/class/leds/platform\:rdled/trigger ```
Both working on my ts7250.
| |