Messages in this thread | | | Date | Wed, 1 Feb 2023 09:46:22 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH v2] net: fec: fix conversion to gpiod API |
| |
On 31.01.2023 19:23:16, Dmitry Torokhov wrote: > The reset line is optional, so we should be using devm_gpiod_get_optional() > and not abort probing if it is not available. Also, there is a quirk in > gpiolib (introduced in b02c85c9458cdd15e2c43413d7d2541a468cde57) that > transparently handles "phy-reset-active-high" property. Remove handling > from the driver to avoid ending up with the double inversion/flipped > logic. > > Fixes: 468ba54bd616 ("fec: convert to gpio descriptor") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de> Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |