Messages in this thread | | | Date | Wed, 1 Feb 2023 23:34:46 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v3 1/2] perf script: Show branch speculation info |
| |
Em Wed, Feb 01, 2023 at 10:13:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jan 30, 2023 at 05:09:10PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Jan 30, 2023 at 04:04:58PM +0530, Sandipan Das escreveu: > > > On 1/30/2023 11:29 AM, Sandipan Das wrote: > > > > Show the branch speculation info if provided by the branch recording > > > > hardware feature. This can be useful for optimizing code further. > > > > > > > > The speculation info is appended to the end of the list of fields so any > > > > existing tools that use "/" as a delimiter for access fields via an index > > > > remain unaffected. Also show "-" instead of "N/A" when speculation info > > > > is unavailable because "/" is used as the field separator. > > > > > > > > E.g. > > > > > > > > $ perf record -j any,u,save_type ./test_branch > > > > $ perf script --fields brstacksym > > > > > > > > Before: > > > > > > > > [...] > > > > check_match+0x60/strcmp+0x0/P/-/-/0/CALL > > > > do_lookup_x+0x3c5/check_match+0x0/P/-/-/0/CALL > > > > [...] > > > > > > > > After: > > > > > > > > [...] > > > > check_match+0x60/strcmp+0x0/P/-/-/0/CALL/NON_SPEC_CORRECT_PATH > > > > do_lookup_x+0x3c5/check_match+0x0/P/-/-/0/CALL/NON_SPEC_CORRECT_PATH > > > > [...] > > > > > > > > Signed-off-by: Sandipan Das <sandipan.das@amd.com> > > > > --- > > > > tools/perf/builtin-script.c | 5 +++-- > > > > tools/perf/util/branch.c | 15 +++++++++++++++ > > > > tools/perf/util/branch.h | 2 ++ > > > > tools/perf/util/evsel.c | 15 ++++++++++++--- > > > > 4 files changed, 32 insertions(+), 5 deletions(-) > > > > > > > > > > Sorry but I realized later that this change breaks the builtin branch test. > > > The additional change below fixes that. > > > > Please wait a bit for people to be able to review the other patches and > > then submit a v2 series. > > So I applied it manually, no need to send v2.
Please send v2 after figuring out why 'perf test "Sample parsing"' fails,
I removed both patches for now.
- Arnaldo
| |