Messages in this thread | | | Date | Fri, 8 Dec 2023 19:01:14 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH v4 2/3] arm64: dts: qcom: pm8916: Add BMS and charger |
| |
On Fri, Dec 08, 2023 at 02:19:11PM +0500, Nikita Travkin wrote: > Bjorn Andersson писал(а) 08.12.2023 07:48: > > On Mon, Nov 20, 2023 at 07:03:04PM +0500, Nikita Travkin wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi > > [..] > >> > >> + pm8916_bms: battery@4000 { > > > > "battery" is not a valid child of the pmic according to > > mfd/qcom,spmi-pmic.yaml, so please update the binding to remove the > > warnings that this introduces. > > > > This should be done in 1/3 which is already accepted to mfd, > so the warning should be gone when the stuff is pulled together. >
Very good. I just didn't spot that for some reason.
> Sorry for not making sure it's in earlier
No fault on your part, I should have spotted it. Sending binding updates and DT updates in the same series is preferred way, and as I don't apply the binding through my tree these warnings show up there.
Thank you, Bjorn
> Nikita > > > Thanks, > > Bjorn
| |