Messages in this thread | | | From | Suman Ghosh <> | Subject | RE: [EXT] [PATCH] ethernet: atheros: fix a memleak in atl1e_setup_ring_resources | Date | Thu, 7 Dec 2023 17:08:15 +0000 |
| |
>diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c >b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c >index 5935be190b9e..deb5a3f207cc 100644 >--- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c >+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c >@@ -866,6 +866,7 @@ static int atl1e_setup_ring_resources(struct >atl1e_adapter *adapter) > netdev_err(adapter->netdev, "offset(%d) > ring size(%d) !!\n", > offset, adapter->ring_size); > err = -1; >+ kfree(tx_ring->tx_buffer); [Suman] I think we should do tx_ring->tx_buffer = NULL also, to avoid use after free? > goto failed; > } > >-- >2.34.1 >
| |