Messages in this thread | | | Subject | Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation | From | Yunsheng Lin <> | Date | Thu, 7 Dec 2023 19:27:09 +0800 |
| |
On 2023/12/7 11:15, Jakub Kicinski wrote: > On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote: >> __GFP_DIRECT_RECLAIM is xor'd to avoid >> direct reclaim in skb_page_frag_refill(), but it is not >> xor'd in __page_frag_cache_refill(). > > xor is not the same thing as masking a bit off.
You are right. Will use 'mask off', thanks.
> The patch itself LGTM. > . >
| |