Messages in this thread | | | Date | Thu, 7 Dec 2023 13:57:44 +0530 | Subject | Re: [PATCH 08/13] scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence() | From | Nitin Rawat <> |
| |
On 12/1/2023 8:44 PM, Manivannan Sadhasivam wrote: > If ufs_qcom_power_up_sequence() fails, then it makes no sense to enable > the lane clocks and continue ufshcd_hba_enable(). So let's check the return > value of ufs_qcom_power_up_sequence(). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/ufs/host/ufs-qcom.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 4948dd732aae..e4dd3777a4d4 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -415,7 +415,10 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, > > switch (status) { > case PRE_CHANGE: > - ufs_qcom_power_up_sequence(hba); > + err = ufs_qcom_power_up_sequence(hba); > + if (err) > + return err; > + > /* > * The PHY PLL output is the source of tx/rx lane symbol > * clocks, hence, enable the lane clocks only after PHY
Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com>
| |