Messages in this thread | | | From | David Gow <> | Date | Fri, 8 Dec 2023 11:07:13 +0800 | Subject | Re: [PATCH v2 1/2] kunit: tool: fix parsing of test attributes |
| |
On Fri, 8 Dec 2023 at 05:34, Rae Moar <rmoar@google.com> wrote: > > Add parsing of attributes as diagnostic data. Fixes issue with test plan > being parsed incorrectly as diagnostic data when located after > suite-level attributes. > > Note that if there does not exist a test plan line, the diagnostic lines > between the suite header and the first result will be saved in the suite > log rather than the first test case log. > > Signed-off-by: Rae Moar <rmoar@google.com> > ---
Thanks, this looks good to me.
Reviewed-by: David Gow <davidgow@google.com>
Cheers, -- David
| |