lkml.org 
[lkml]   [2023]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 0/3] supplement of slab allocator removal
Date


> -----Original Message-----
> From: Vlastimil Babka <vbabka@suse.cz>
> Sent: Thursday, December 7, 2023 12:13 AM
> To: sxwjean@me.com; 42.hyeyoo@gmail.com; cl@linux.com; linux-
> mm@kvack.org
> Cc: penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com;
> roman.gushchin@linux.dev; corbet@lwn.net; keescook@chromium.org;
> arnd@arndb.de; akpm@linux-foundation.org; gregkh@linuxfoundation.org;
> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; Song, Xiongwei
> <Xiongwei.Song@windriver.com>
> Subject: Re: [PATCH v2 0/3] supplement of slab allocator removal
>
> On 12/3/23 01:14, sxwjean@me.com wrote:
> > From: Xiongwei Song <xiongwei.song@windriver.com>
> >
> > Hi,
> >
> > Patch 1 is to remove an unused parameter. This patch actually is v3, but
> > it is not reasonable to add v3 tag in the cover letter, so I put the
> > change history inside the patch.
> >
> > ---
> > Patch 2 is to replace slub_$params with slab_$params.
> > Vlastimil Babka pointed out we should use "slab_$param" as the primary
> > prefix for long-term plan. Please see [1] for more information.
> >
> > This patch is to do that. However, the patch is big, I'm not sure if
> > everything is proper in it, so I added "RFC" in the patch title. For more
> > information please see the commit message of patch.
> >
> > I did the basic tests with qemu, which passed values by sl[au]b_max_order,
> > sl[au]b_min_order, sl[au]b_min_objects and sl[au]b_debug in command
> line.
> > The values looks correct by printing them out before calculating orders.
> >
> > One thing I'm not sure about the forth parameter of __setup_param(),
> > Is it correct to set the parameter to 0 directly?
>
> Yep it's fine.

Thanks for the confirmation.
\
 
 \ /
  Last update: 2023-12-08 03:04    [W:0.227 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site