lkml.org 
[lkml]   [2023]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/3] scsi: ufs: core: Add UFS RTC support
From
Date
On Wed, 2023-12-06 at 14:59 -1000, Bart Van Assche wrote:
> A 64-bit value is truncated to a 32-bit value. What should happen if
> the
> right hand side is larger than what fits into a 32-bit integer?
> Should
> a comment perhaps be added that uptimes of more than 136 years are
> not
> supported and also for absolute times that the above code fails after
> the year 2010 + 136 = 2146?
>
> Thanks,
>
> Bart.


Bart,

you are taking into account a broader perspective. thanks for your
review!

I will add below code in the next version:


+ if (ts64.tv_sec < hba->dev_info.rtc_time_baseline) {
+ dev_warn(hba->dev, "%s: Current time precedes previous
setting!\n", __func__);
+ return;
+ }
+ /*
+ * Absolute RTC mode has 136-year limit as of 2010. Modify UFS
Spec or choosing relative
+ * RTC mode for longer (beyond year 2146) time spans.
+ */


Kind regards,
Bean

\
 
 \ /
  Last update: 2023-12-08 00:05    [W:0.138 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site