Messages in this thread | | | From | Wei Fang <> | Subject | RE: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to ethtool_puts() | Date | Thu, 7 Dec 2023 07:19:56 +0000 |
| |
> -----Original Message----- > From: justinstitt@google.com <justinstitt@google.com> > Sent: 2023年12月7日 7:16 > To: David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; Shay Agroskin <shayagr@amazon.com>; Arthur > Kiyanovski <akiyano@amazon.com>; David Arinzon > <darinzon@amazon.com>; Noam Dagan <ndagan@amazon.com>; Saeed > Bishara <saeedb@amazon.com>; Rasesh Mody <rmody@marvell.com>; > Sudarsana Kalluru <skalluru@marvell.com>; GR-Linux-NIC-Dev@marvell.com; > Dimitris Michailidis <dmichail@fungible.com>; Yisen Zhuang > <yisen.zhuang@huawei.com>; Salil Mehta <salil.mehta@huawei.com>; Jesse > Brandeburg <jesse.brandeburg@intel.com>; Tony Nguyen > <anthony.l.nguyen@intel.com>; Louis Peens <louis.peens@corigine.com>; > Shannon Nelson <shannon.nelson@amd.com>; Brett Creeley > <brett.creeley@amd.com>; drivers@pensando.io; K. Y. Srinivasan > <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Wei Liu > <wei.liu@kernel.org>; Dexuan Cui <decui@microsoft.com>; Ronak Doshi > <doshir@vmware.com>; VMware PV-Drivers Reviewers > <pv-drivers@vmware.com>; Andy Whitcroft <apw@canonical.com>; Joe > Perches <joe@perches.com>; Dwaipayan Ray <dwaipayanray1@gmail.com>; > Lukas Bulwahn <lukas.bulwahn@gmail.com>; Hauke Mehrtens > <hauke@hauke-m.de>; Andrew Lunn <andrew@lunn.ch>; Florian Fainelli > <f.fainelli@gmail.com>; Vladimir Oltean <olteanv@gmail.com>; Arınç ÜNAL > <arinc.unal@arinc9.com>; Daniel Golle <daniel@makrotopia.org>; Landen > Chao <Landen.Chao@mediatek.com>; DENG Qingfang <dqfext@gmail.com>; > Sean Wang <sean.wang@mediatek.com>; Matthias Brugger > <matthias.bgg@gmail.com>; AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com>; Linus Walleij > <linus.walleij@linaro.org>; Alvin Šipraga <alsi@bang-olufsen.dk>; Wei Fang > <wei.fang@nxp.com>; Shenwei Wang <shenwei.wang@nxp.com>; Clark > Wang <xiaoning.wang@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; Lars > Povlsen <lars.povlsen@microchip.com>; Steen Hegelund > <Steen.Hegelund@microchip.com>; Daniel Machon > <daniel.machon@microchip.com>; UNGLinuxDriver@microchip.com; Jiawen > Wu <jiawenwu@trustnetic.com>; Mengyuan Lou > <mengyuanlou@net-swift.com>; Heiner Kallweit <hkallweit1@gmail.com>; > Russell King <linux@armlinux.org.uk>; Alexei Starovoitov <ast@kernel.org>; > Daniel Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer > <hawk@kernel.org>; John Fastabend <john.fastabend@gmail.com> > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; Nick Desaulniers > <ndesaulniers@google.com>; Nathan Chancellor <nathan@kernel.org>; Kees > Cook <keescook@chromium.org>; intel-wired-lan@lists.osuosl.org; > oss-drivers@corigine.com; linux-hyperv@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; > bpf@vger.kernel.org; Justin Stitt <justinstitt@google.com> > Subject: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to > ethtool_puts() > > This patch converts some basic cases of ethtool_sprintf() to ethtool_puts(). > > The conversions are used in cases where ethtool_sprintf() was being used > with just two arguments: > | ethtool_sprintf(&data, buffer[i].name); > or when it's used with format string: "%s" > | ethtool_sprintf(&data, "%s", buffer[i].name); > which both now become: > | ethtool_puts(&data, buffer[i].name); > > Signed-off-by: Justin Stitt <justinstitt@google.com> > --- > drivers/net/ethernet/freescale/fec_main.c | 4 +- > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index c3b7694a7485..bae9536de767 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -2932,10 +2932,10 @@ static void fec_enet_get_strings(struct > net_device *netdev, > switch (stringset) { > case ETH_SS_STATS: > for (i = 0; i < ARRAY_SIZE(fec_stats); i++) { > - ethtool_sprintf(&data, "%s", fec_stats[i].name); > + ethtool_puts(&data, fec_stats[i].name); > } > for (i = 0; i < ARRAY_SIZE(fec_xdp_stat_strs); i++) { > - ethtool_sprintf(&data, "%s", fec_xdp_stat_strs[i]); > + ethtool_puts(&data, fec_xdp_stat_strs[i]); > } > page_pool_ethtool_stats_get_strings(data); >
Reviewed-by: Wei Fang <wei.fang@nxp.com>
| |