Messages in this thread | | | Date | Thu, 7 Dec 2023 20:00:07 +0100 | From | Michal Koutný <> | Subject | Re: [PATCH 1/1] mm: add swapiness= arg to memory.reclaim |
| |
On Wed, Dec 06, 2023 at 08:28:56AM -0800, Dan Schatzberg <schatzberg.dan@gmail.com> wrote: > @@ -6902,12 +6913,33 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, ... > + int swappiness = -1;
Here you use a negative number...
> @@ -136,6 +136,9 @@ struct scan_control { ... > + /* Swappiness value for reclaim, if NULL use memcg/global value */ > + int *swappiness;
... and here a NULL to denote the unset value.
I'd suggest unifying those. Perhaps the negative to avoid unnecessary dereferences.
Thanks, Michal [unhandled content-type:application/pgp-signature] | |