Messages in this thread | | | Date | Mon, 25 Dec 2023 23:49:57 +0800 (GMT+08:00) | From | alexious@zju ... | Subject | Re: Re: [PATCH] SUNRPC: fix some memleaks in gssx_dec_option_array |
| |
> > On Sun, Dec 24, 2023 at 04:24:22PM +0800, Zhipeng Lu wrote: > > The creds and oa->data need to be freed in the error-handling paths after > > there allocation. So this patch add these deallocations in the > > corresponding paths. > > > > Fixes: 1d658336b05f ("SUNRPC: Add RPC based upcall mechanism for RPCGSS auth") > > Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn> > > ... > > > diff --git a/net/sunrpc/auth_gss/gss_rpc_xdr.c b/net/sunrpc/auth_gss/gss_rpc_xdr.c > > ... > > > @@ -265,29 +265,41 @@ static int gssx_dec_option_array(struct xdr_stream *xdr, > > > > /* option buffer */ > > p = xdr_inline_decode(xdr, 4); > > - if (unlikely(p == NULL)) > > - return -ENOSPC; > > + if (unlikely(p == NULL)) { > > + err = -ENOSPC > > Hi Zhipeng Lu, > > unfortunately the line above causes a build failure. > > ...
Sorry for my mistake, I'll send a version 2 of this patch soon.
| |