Messages in this thread | | | Date | Mon, 25 Dec 2023 14:37:00 +0100 | Subject | Re: [PATCH v2 02/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add pressure-triplet | From | Krzysztof Kozlowski <> |
| |
On 25/12/2023 14:34, Krzysztof Kozlowski wrote: >>>> +oneOf: >>>> + - required: >>>> + - honeywell,pmin-pascal >>>> + - honeywell,pmax-pascal >>>> + - required: >>>> + - honeywell,pressure-triplet >>>> + >>>> +allOf: >>>> + - if: >>>> + required: >>>> + - honeywell,pressure-triplet >>>> + then: >>>> + properties: >>>> + honeywell,pmin-pascal: false >>>> + honeywell,pmax-pascal: false >>> >>> This allOf is not needed. >> >> speaking for intricacies, if the allOf is removed, then a binding containing >> >> honeywell,pmax-pascal = <840000>; >> honeywell,pressure-triplet = "0015PA"; >> >> would be considered to be correct by the schema, but that would be the incorrect >> result. so afaict allOf needs to stay, and so does the redundant text. > > Really? Did you test it?
Hm, indeed, on pmin/pmax would not trigger first required case. OK, then this part make sense.
Best regards, Krzysztof
| |