Messages in this thread | | | Date | Thu, 21 Dec 2023 17:53:36 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode |
| |
On Thu, Dec 21, 2023 at 06:13:43PM +0800, Shenghao Ding wrote: > Support dsp mode for tas2563.
DSP
...
> +// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier
Why not ordered?
...
> +// The TAS2781/TAS2563 driver implements a flexible and configurable
Ditto.
...
> +// TAS2781/TAS2563 chips.
Ditto.
...
> enum audio_device { > TAS2781 = 0, > + TAS2563
Missing comma as this is not a terminator.
> };
Ditto.
...
I would expect here
enum audio_device { TAS2563, TAS2781, };
-- With Best Regards, Andy Shevchenko
| |