lkml.org 
[lkml]   [2023]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode
On Thu, Dec 21, 2023 at 06:13:43PM +0800, Shenghao Ding wrote:
> Support dsp mode for tas2563.

DSP

...

> +// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier

Why not ordered?

...

> +// The TAS2781/TAS2563 driver implements a flexible and configurable

Ditto.

...

> +// TAS2781/TAS2563 chips.

Ditto.

...

> enum audio_device {
> TAS2781 = 0,
> + TAS2563

Missing comma as this is not a terminator.

> };

Ditto.

...

I would expect here

enum audio_device {
TAS2563,
TAS2781,
};

--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2023-12-21 16:54    [W:0.275 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site