| Date | Thu, 21 Dec 2023 15:42:17 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 00/22] Improve IRQ wake capability reporting and update the cros_ec driver to use it |
| |
On Wed, Dec 20, 2023 at 04:54:14PM -0700, Mark Hasemeyer wrote: > Currently the cros_ec driver assumes that its associated interrupt is > wake capable. This is an incorrect assumption as some Chromebooks use a > separate wake pin, while others overload the interrupt for wake and IO. > This patch train updates the driver to query the underlying ACPI/DT data > to determine whether or not the IRQ should be enabled for wake. > > Both the device tree and ACPI systems have methods for reporting IRQ > wake capability. In device tree based systems, a node can advertise > itself as a 'wakeup-source'. In ACPI based systems, GpioInt and > Interrupt resource descriptors can use the 'SharedAndWake' or > 'ExclusiveAndWake' share types. > > Some logic is added to the platform, ACPI, and DT subsystems to more > easily pipe wakeirq information up to the driver.
Just wondering if you used --histogram diff algo when preparing patches.
-- With Best Regards, Andy Shevchenko
|