Messages in this thread | | | From | Dmitry Baryshkov <> | Date | Thu, 21 Dec 2023 15:18:49 +0200 | Subject | Re: [PATCH 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler |
| |
On Thu, 21 Dec 2023 at 15:16, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 21.12.2023 14:04, Dmitry Baryshkov wrote: > > On Thu, 21 Dec 2023 at 15:01, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > >> > >> On 21.12.2023 04:50, Bjorn Andersson wrote: > >>> The GX GDSC is modelled to aid the GMU in powering down the GPU in the > >>> event that the GPU crashes, so that it can be restarted again. But in > >>> the event that the power-domain is supplied through a dedicated > >>> regulator (in contrast to being a subdomin of another power-domain), > >>> something needs to turn that regulator on, both to make sure things are > >>> powered and to match the operation in gdsc_disable(). > >>> > >>> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > >>> --- > >>> drivers/clk/qcom/gdsc.c | 8 +++++++- > >>> 1 file changed, 7 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c > >>> index 5358e28122ab..d1139c895503 100644 > >>> --- a/drivers/clk/qcom/gdsc.c > >>> +++ b/drivers/clk/qcom/gdsc.c > >>> @@ -557,7 +557,13 @@ void gdsc_unregister(struct gdsc_desc *desc) > >>> */ > >>> int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain) > >> I suppose the name is confusing now.. > >> > >> But at the same time I can't come up with anything that's less than > >> like 6 words.. > > > > gdsc_gx_enable() ;-) > except not really only gx and not really enable :( > > gdsc_shared_enable would probably be closer to our current > nomenclature..
gdsc_dummy_gx_enable*(
Or gdsc_dummy_gmu_gx_enable(). Still less than 6 words. I'm trying my best!
-- With best wishes Dmitry
| |