Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 14:54:03 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 2/2] gpio: sysfs: drop tabs from local variable declarations |
| |
On Thu, Dec 21, 2023 at 10:15:47AM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Older code has an annoying habit of putting tabs between the type and the > name of the variable. This doesn't really add to readability and newer > code doesn't do it so make the entire file consistent.
...
> + long gpio; > + struct gpio_desc *desc; > + int status;
Not fully reversed xmas tree order...
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |