Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 14:41:27 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/2] mfd: intel-lpss: Switch to generalized quirk table |
| |
On Wed, Dec 20, 2023 at 09:56:20PM +0100, Aleksandrs Vinarskis wrote: > Introduce generic quirk table, and port existing walkaround for select > Microsoft devices to it. This is a preparation for > QUIRK_CLOCK_DIVIDER_UNITY.
Thank you for the update! Some nit-picks below, after addressing them feel free to add Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> - { }
> + {}
No need to change here.
Also I'm not sure about "}, {" style. Lee as the maintainer can clarify on this.
...
> const struct intel_lpss_platform_info *data = (void *)id->driver_data; > struct intel_lpss_platform_info *info; > + const struct pci_device_id *quirk_pci_info; > int ret;
I would preserve reversed xmas tree order:
const struct intel_lpss_platform_info *data = (void *)id->driver_data; const struct pci_device_id *quirk_pci_info; struct intel_lpss_platform_info *info; int ret;
...
> + quirk_pci_info = pci_match_id(quirk_ids, pdev); > + if (quirk_pci_info) > + info->quirks = quirk_pci_info->driver_data;
Can you confirm that there is no compiler warning if you compile for 32-bit?
...
> +/* > + * Some DSDTs have an unused GEXP ACPI device conflicting with I2C4 resources > + * Set to ignore resource conflicts with ACPI declared SystemMemory regions
Please, mind the periods at the ends of sentences.
> + */
...
> + unsigned int quirks;
Depending on the above (32-bit compilation) this might be converted to unsigned long.
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |