Messages in this thread | | | Date | Thu, 21 Dec 2023 12:40:15 +0100 | From | Dimitri Fedrau <> | Subject | Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY |
| |
Am Thu, Dec 21, 2023 at 10:53:27AM +0100 schrieb Andrew Lunn: > > -static int mv88q2xxxx_get_sqi(struct phy_device *phydev) > > +static int mv88q2xxx_get_sqi(struct phy_device *phydev) > > { > > int ret; > > > > @@ -208,7 +283,8 @@ static int mv88q2xxxx_get_sqi(struct phy_device *phydev) > > /* Read the SQI from the vendor specific receiver status > > * register > > */ > > - ret = phy_read_mmd(phydev, MDIO_MMD_PCS, 0x8230); > > + ret = phy_read_mmd(phydev, MDIO_MMD_PCS, > > + MDIO_MMD_PCS_MV_RX_STAT); > > if (ret < 0) > > return ret; > > > > @@ -230,11 +306,208 @@ static int mv88q2xxxx_get_sqi(struct phy_device *phydev) > > return ret & 0x0F; > > } > > > > -static int mv88q2xxxx_get_sqi_max(struct phy_device *phydev) > > +static int mv88q2xxx_get_sqi_max(struct phy_device *phydev) > > { > > return 15; > > } > > This could be a patch of its own. > Will fix this in V4.
> Andrew
Best regards, Dimitri
| |