Messages in this thread | | | Date | Thu, 21 Dec 2023 10:13:46 +0100 | Subject | Re: [RESEND PATCH v5 1/2] dt-bindings: i2c: pca954x: Add custom properties for MAX7357 | From | Krzysztof Kozlowski <> |
| |
On 20/12/2023 21:50, Wolfram Sang wrote: > On Wed, Dec 20, 2023 at 01:58:01PM +0530, Naresh Solanki wrote: >> From: Patrick Rudolph <patrick.rudolph@9elements.com> >> >> Maxim Max7357 has a configuration register to enable additional >> features. These features aren't enabled by default & its up to >> board designer to enable the same as it may have unexpected side effects. >> >> These should be validated for proper functioning & detection of devices >> in secondary bus as sometimes it can cause secondary bus being disabled. >> >> Add booleans for: >> - maxim,isolate-stuck-channel >> - maxim,send-flush-out-sequence >> - maxim,preconnection-wiggle-test-enable >> >> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> >> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Rob, are you really OK with these bindings? They look more like > configuration instead of HW description to me.
Some explanation was provided here: https://lore.kernel.org/all/CABqG17g8QOgU7cObe=4EMLbEC1PeZWxdPXt7zzFs35JGqpRbfg@mail.gmail.com/
AFAIU, these properties are board-design choice.
Best regards, Krzysztof
| |