lkml.org 
[lkml]   [2023]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] bridge: cfm: fix enum typo in br_cc_ccm_tx_parse
Hello Simon,

>
> Thanks Lin Ma,
>
> I agree with your analysis, that the problem was introduced in the
> cited commit, and that it is resolved by your patch.
>

Thanks for the encouragement.

> However, as there is no user-visible bug I don't believe this reaches
> the bar for a 'fix' for Networking code. Accordingly, I think that
> the Fixes tag should be dropped. And, instead cited commit can be mentioned
> using something like "This problem was introduced by commit ...".
>
> Also, as I don't think it is a fix I think it should be targeted at the
> net-next tree:
>
> Subject: [PATCH net-next vX] ...
>

Copy that. Yeah, once the enum IFLA_BRIDGE_CFM_CC_RDI_INSTANCE and the
IFLA_BRIDGE_CFM_CC_CCM_TX_INSTANCE keeps the value 1, everything should work
as usual. I will resend the patch as told.

> The above nits notwithstanding,
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>

Regards
Lin
\
 
 \ /
  Last update: 2023-12-20 17:30    [W:0.069 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site