lkml.org 
[lkml]   [2023]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs
On Fri, 22 Dec 2023 10:52:00 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> > +instance="foo-$(mktemp -u XXXXX)"
> >
> > This doesn't work. it needs XXXXXX (6 times X). And this is
> > somewhat wrong usage of mktemp because it can not check there is
> > foo-<random>.
> > What about change it as
> >
> > instance="$(mktemp -u foo-XXXXXX)"

That can work too, although I think I'll change it from "foo" to "test".

> >
> > ?
>
> And I confirmed that this test passed on v6.5.13 with that change.

Thanks, I'll send out a v3 with 6 Xs. ;-)

-- Steve

\
 
 \ /
  Last update: 2023-12-22 03:02    [W:0.077 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site