Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 15:26:04 -0800 | Subject | Re: [PATCH 3/3] nvdimm/namespace: fix kernel-doc for function params | From | Randy Dunlap <> |
| |
On 12/21/23 14:32, Ira Weiny wrote: > Randy Dunlap wrote: > > [snip] > >> @@ -1656,8 +1664,10 @@ static int select_pmem_id(struct nd_regi >> /** >> * create_namespace_pmem - validate interleave set labelling, retrieve label0 >> * @nd_region: region with mappings to validate >> - * @nspm: target namespace to create >> + * @nd_mapping: container of dpa-resource-root + labels >> * @nd_label: target pmem namespace label to evaluate >> + * >> + * Returns: the created &struct device on success or -errno on error > > NIT: should this be ERR_PTR(-errno) on error?
Oh, for sure. Thanks for catching that.
> Generally good to me though. > > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > >> */ >> static struct device *create_namespace_pmem(struct nd_region *nd_region, >> struct nd_mapping *nd_mapping,
-- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html
| ![\](/images/icornerr.gif) |