Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 22:13:01 +0100 | Subject | Re: [PATCH v1 0/2] w1: add UART w1 bus driver | From | Krzysztof Kozlowski <> |
| |
On 21/12/2023 07:50, Christoph Winklhofer wrote: > Hello! > > Krzysztof, thank your very much for your feedback! > > This patch contains a driver for a 1-Wire bus over UART. The driver > utilizes the UART interface via the Serial Device Bus to create the > 1-Wire timing patterns. > > Version 1 >
You already sent v1, so this is v2:
b4 diff '<20231221065049.30703-1-cj.winklhofer@gmail.com>' Grabbing thread from lore.kernel.org/all/20231221065049.30703-1-cj.winklhofer@gmail.com/t.mbox.gz --- Analyzing 4 messages in the thread ERROR: Could not auto-find previous revision Run "b4 am -T" manually, then "b4 diff -m mbx1 mbx2"
I still cannot find the changelog. Does it mean nothing improved?
> - In v1, the driver requests a baud-rate (9600 for reset and 115200 for > write/read) and tries to adapt the transmitted byte according to the > actual baud-rate returned from serdev. Is this the correct direction or > should the baud-rate be specified in the device-tree? Alternatively, > it could make sense to specify the minimum and maximum times for the > 1-Wire operations in the device-tree, instead of using hard-coded ones > similar as in "Figure 11. Configuration tab" of the linked document > "Using UART to Implement a 1-Wire Bus Master".
Depends, are these hardware properties? Are these runtime? What do they depend on?
> > - In addition, the received byte is now protected with a mutex - instead > of the atomic, which I used before due to the concurrent store and load. > > - Receiving more than one byte results in an error, since the w1-uart > driver is the only writer, it writes a single-byte and should receive > a single byte. > > Changes: > - support different baud-rates > - fix variable names, errno-returns, wrong define CONFIG_OF > - fix log flooding > - fix locking problem for serdev-receive and w1-master reset/touch > - fix driver remove (error-path for rxtx-function) > - add documentation for dt-binding
So this looks like changelog. Please make it explicit - move it to the beginning of cover letter and say "changes in v2".
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |