Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 19:45:47 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] mfd: intel-lpss: Switch to generalized quirk table |
| |
On Thu, Dec 21, 2023 at 07:44:14PM +0200, Andy Shevchenko wrote: > On Thu, Dec 21, 2023 at 06:11:13PM +0100, Aleksandrs Vinarskis wrote:
...
> > +static const struct pci_device_id quirk_ids[] = { > > /* Microsoft Surface Go (version 1) I2C4 */ > > - { PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x9d64, 0x152d, 0x1182), }, > > + { PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x9d64, 0x152d, 0x1182), > > + .driver_data = QUIRK_IGNORE_RESOURCE_CONFLICTS }, > > /* Microsoft Surface Go 2 I2C4 */ > > - { PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x9d64, 0x152d, 0x1237), }, > > + { PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x9d64, 0x152d, 0x1237), > > + .driver_data = QUIRK_IGNORE_RESOURCE_CONFLICTS }, > > { } > > }; > > I would suggest to look at the existing style, as I also in doubts on the > above. Perhaps the following is more common in MFD subsystem? > > { > PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x9d64, 0x152d, 0x1237), > .driver_data = QUIRK_IGNORE_RESOURCE_CONFLICTS
Ah, and in this form we usually leave trailing comma as we don't know the future (possible, but quite unlikely, new fields in the structure).
> },
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |